Skip to content

fix: configure keepAlive time for gRPC TCP connections #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 28, 2025
Merged

fix: configure keepAlive time for gRPC TCP connections #1448

merged 9 commits into from
Oct 28, 2025

Conversation

@rahul2393
Copy link
Contributor

@rahul2393 rahul2393 commented Oct 27, 2025 •
edited
Loading

Issue: b/447183913, b/454523963

NodeJS PR: http://github.com/googleapis/nodejs-spanner/pull/2445
Go PR: googleapis/google-cloud-go#13216

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@rahul2393 rahul2393 requested review from a team as code owners October 27, 2025 06:16
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/python-spanner API. labels Oct 27, 2025
@surbhigarg92 surbhigarg92 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 27, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 27, 2025
@rahul2393
Copy link
Contributor Author

rahul2393 commented Oct 27, 2025

@parthea can you please help review these changes, is it ok to commit these in autogenerated files will these changes persist if any changes come from owlbot in future?

@rahul2393 rahul2393 requested a review from parthea October 27, 2025 06:23
sakthivelmanii
sakthivelmanii previously approved these changes Oct 27, 2025
View reviewed changes
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Oct 27, 2025
surbhigarg92
surbhigarg92 previously approved these changes Oct 28, 2025
View reviewed changes
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Oct 28, 2025
@rahul2393 rahul2393 merged commit efb2833 into main Oct 28, 2025
23 checks passed
@rahul2393 rahul2393 deleted the set_default_keepalive_time branch October 28, 2025 17:24
@release-please release-please bot mentioned this pull request Oct 28, 2025
Open
@ohmayr ohmayr mentioned this pull request Nov 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthea parthea parthea approved these changes

@surbhigarg92 surbhigarg92 surbhigarg92 left review comments

@sakthivelmanii sakthivelmanii sakthivelmanii left review comments

Assignees

@harshachinta harshachinta

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rahul2393 @parthea @surbhigarg92 @sakthivelmanii @harshachinta