Skip to content
This repository was archived by the owner on Feb 18, 2024. It is now read-only.

Conversation

@alexander-fenster
Copy link
Contributor

@alexander-fenster alexander-fenster commented Mar 23, 2018

@stephenplusplus, @callmehiphop: it would be great to have #47 included in this release, hope it can get approved soon. Let's wait for that PR before merging this one.


Features

In this minor release we updated some protos used by v1p1beta1 endpoint (added optional metadata field to RecognitionConfig message). There is no need to change any existing code. Also, v1 endpoint is still default. If you want to try using the new v1p1beta1 endpoint, you need to request it in your code:

const speech = require('@google-cloud/nodejs-speech').v1p1beta1;

Fixes


Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

## Features

In this minor release we updated some protos used by `v1p1beta1` endpoint (added optional `metadata` field to `RecognitionConfig` message). There is no need to change any existing code. Also, `v1` endpoint is still default. If you want to try using the new `v1p1beta1` endpoint, you need to request it in your code:
```js
const speech = require('@google-cloud/nodejs-speech).v1p1beta1;
```
@alexander-fenster alexander-fenster added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 23, 2018
@ghost ghost added the cla: yes This human has signed the Contributor License Agreement. label Mar 23, 2018
@codecov
Copy link

codecov bot commented Mar 23, 2018

Codecov Report

Merging #49 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #49   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          29     29           
=====================================
  Hits           29     29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c96a60...1c55774. Read the comment docs.

@alexander-fenster alexander-fenster changed the title DO NOT MERGE: release 1.3.0 release 1.3.0 Mar 23, 2018
@alexander-fenster alexander-fenster removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 23, 2018
@alexander-fenster alexander-fenster merged commit 989c580 into master Mar 23, 2018
@ghost ghost removed the cla: yes This human has signed the Contributor License Agreement. label Mar 23, 2018
@alexander-fenster alexander-fenster deleted the release-1.3.0 branch March 23, 2018 19:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants