feat(userAgent): allow for optional user agent to be provided

[averikitsch]

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

• Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

[averikitsch]

@JustinBeckwith

[JustinBeckwith]

I can't say with 100% confidence what we want to have happen on the backend will happen, because storage has some weirdness with OnePlatform and usage tracking. @frankyn is there a way to test this? That having been said, this don't hurt.

[frankyn]

I'll follow-up with both of you over email due to internal only information.

[averikitsch]

Looks like the system tests may be flaky.

[frankyn]

Project overground may be causing this... will raise in today's sync and report back.

cc: @amanda-tarafa

  1) storage
       HMAC keys
         should create an HMAC key for a service account:
     Error: Request violates constraint 'constraints/iam.disableServiceAccountKeyCreation'
      at new ApiError (node_modules/@google-cloud/common/build/src/util.js:59:15)
      at Util.parseHttpRespBody (node_modules/@google-cloud/common/build/src/util.js:194:38)
      at Util.handleResp (node_modules/@google-cloud/common/build/src/util.js:135:117)
      at /workspace/node_modules/@google-cloud/common/build/src/util.js:434:22
      at onResponse (node_modules/retry-request/index.js:214:7)
      at /workspace/node_modules/teeny-request/build/src/index.js:219:13
          -> /workspace/node_modules/teeny-request/src/index.ts:325:11
      at runMicrotasks (<anonymous>)
      at processTicksAndRejections (internal/process/task_queues.js:97:5

[amanda-tarafa]

Yes, definetely seems to be related to overground. Create an internal bug, and assign it to me, with the following info:

• Project ID this is happening.
• What exactly is this method trying to do? Is it really trying to create and download a Service Account Key?

[codecov]

Codecov Report

Merging #1313 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1313   +/-   ##
=======================================
  Coverage   99.00%   99.00%           
=======================================
  Files          14       14           
  Lines       11712    11715    +3     
  Branches      582      582           
=======================================
+ Hits        11595    11598    +3     
  Misses        117      117           

Impacted Files	Coverage Δ
src/storage.ts	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ec256e...5982450. Read the comment docs.