Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

samples: storage.objects.insert precondition samples#2047

Merged
shaffeeullah merged 7 commits intoshaffeeullah/preconditionsamplesfrom
shaffeeullah/storage.objects.insertpreconditions
Aug 18, 2022
Merged

samples: storage.objects.insert precondition samples#2047
shaffeeullah merged 7 commits intoshaffeeullah/preconditionsamplesfrom
shaffeeullah/storage.objects.insertpreconditions

Conversation

@shaffeeullah
Copy link
Copy Markdown
Contributor

No description provided.

shaffeeullah and others added 6 commits August 12, 2022 11:33
Co-authored-by: Sameena Shaffeeullah <shaffeeullah@google.com>
…pload Connection Errors (#2040)

* feat: Add `epipe` as retryable error

* fix: capture and retry potential connection errors

* test: Add tests and remove logs

* test: set `retryOptions` by copy rather than reference

* fix: grammar
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/nodejs-storage API. samples Issues that are directly related to samples. labels Aug 18, 2022
@shaffeeullah shaffeeullah changed the base branch from main to shaffeeullah/preconditionsamples August 18, 2022 18:25
@shaffeeullah shaffeeullah marked this pull request as ready for review August 18, 2022 18:25
@shaffeeullah shaffeeullah requested review from a team August 18, 2022 18:25
@shaffeeullah shaffeeullah merged commit ca1b4b7 into shaffeeullah/preconditionsamples Aug 18, 2022
@shaffeeullah shaffeeullah deleted the shaffeeullah/storage.objects.insertpreconditions branch August 18, 2022 18:25
shaffeeullah added a commit that referenced this pull request Aug 18, 2022
@shaffeeullah shaffeeullah restored the shaffeeullah/storage.objects.insertpreconditions branch August 18, 2022 18:27
@shaffeeullah shaffeeullah deleted the shaffeeullah/storage.objects.insertpreconditions branch August 18, 2022 18:30
shaffeeullah added a commit that referenced this pull request Aug 18, 2022
…s.insert, storage.objects.patch, & storage.objects.delete samples (#2046)

* started copy sample

* samples: add preconditions to storage.objects.rewrite & storage.objects.delete samples

* linted files

* samples: storage.objects.insert precondition samples

* updated test

* samples: storage.objects.insert precondition samples (#2047)

* test: add retries (#2039)

* refactor: remove unused `restart` private method (#2038)

Co-authored-by: Sameena Shaffeeullah <shaffeeullah@google.com>

* fix: Retry `EPIPE` Connection Errors + Attempt Retries in Resumable Upload Connection Errors (#2040)

* feat: Add `epipe` as retryable error

* fix: capture and retry potential connection errors

* test: Add tests and remove logs

* test: set `retryOptions` by copy rather than reference

* fix: grammar

* chore(main): release 6.4.1 (#2036)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* test: add delay to bucket tests to reduce rate limiting errors (#2043)

* samples: storage.objects.insert precondition samples

* updated test

Co-authored-by: Daniel Bankhead <danielbankhead@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Denis DelGrosso <85250797+ddelgrosso1@users.noreply.github.com>

* Revert "samples: storage.objects.insert precondition samples (#2047)" (#2048)

This reverts commit ca1b4b7.

* storage.objects.patch sample updates

* destinationGenerationMatchPrecondition

* renamed variable

Co-authored-by: Daniel Bankhead <danielbankhead@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Denis DelGrosso <85250797+ddelgrosso1@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/nodejs-storage API. samples Issues that are directly related to samples. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants