This repository was archived by the owner on Mar 3, 2026. It is now read-only.
feat: add crc32c validation option to chunked download, cleanup naming#2110
Merged
ddelgrosso1 merged 2 commits intogoogleapis:transfer-managerfrom Dec 6, 2022
Merged
Conversation
product-auto-label
Bot
added
size: m
shaffeeullah
approved these changes
Dec 6, 2022
Contributor
shaffeeullah
left a comment
shaffeeullah
left a comment
There was a problem hiding this comment.
looks good! pls double check that docs check failure is expected before merging.
frankyn
reviewed
Dec 6, 2022
Contributor
frankyn
left a comment
frankyn
left a comment
There was a problem hiding this comment.
Just had one question; otherwise LGTM
| .then(data => { | ||
| results = data.map(result => result.buffer) as DownloadResponse; | ||
| if (options.validation === 'crc32c') { | ||
| return CRC32C.fromFile(filePath); |
Contributor
There was a problem hiding this comment.
Is this a post processing hash validation step once for both single download and multi-chunk download?
Contributor
Author
There was a problem hiding this comment.
This is a post-file download CRC32C validation (if enabled). It will occur if the user opts in and the file is downloaded as a single chunk or mutichunks
Contributor
Author
|
@shaffeeullah docs failure is because of 404 for the new samples I added. |
ddelgrosso1
added a commit
that referenced
this pull request
Dec 7, 2022
* feat: implement parallel operations (#2067) * feat: implement parallel operations * add more parallel operations * add header to test file * update import of fs/promises * fix pathing on windows, fix mocking of fs promises * add jsdoc headers to class and uploadMulti * add jsdoc comments to remaining functions * update comment wording * add experimental jsdoc tags * feat: add directory generator to performance test framework * clarify variable names and comments * capitalization * wip: transfer manager performance tests * feat: merged in application performance tests (#2100) * fix: fixed many bugs (#2102) * fix: cleaning up bugs * fix: fixed many bugs * fix: more work on transfer manager perf metrics (#2103) * fix: more work on transfer manager perf metrics * fix unit tests for tm * fix: performance test refactoring, comments (#2104) * refactor: refactor constants (#2105) * refactor: refactor constants * bug fixes * bug fixes * bug fixes * linter fixes, download to disk for performance test * rename transfer manager functions * remove callbacks from transfer manager * add more experimental tags, update comments * change signature of downloadManyFiles to accept array of strings or a folder name * linter fix * add transfer manager samples and samples tests Co-authored-by: Sameena Shaffeeullah <shaffeeullah@google.com> * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * feat: add crc32c validation option to chunked download, cleanup naming (#2110) * feat: add crc32c validation option to chunked download, cleanup naming in perf tests * close file in finally block Co-authored-by: Sameena Shaffeeullah <shaffeeullah@google.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕