This repository was archived by the owner on Oct 17, 2023. It is now read-only.
refactor(samples): convert sample tests from ava to mocha#171
Merged
JustinBeckwith merged 2 commits intogoogleapis:masterfrom Nov 15, 2018
nareshqlogic:sample_ava_to_mocha
Merged
refactor(samples): convert sample tests from ava to mocha#171JustinBeckwith merged 2 commits intogoogleapis:masterfrom nareshqlogic:sample_ava_to_mocha
JustinBeckwith merged 2 commits intogoogleapis:masterfrom
nareshqlogic:sample_ava_to_mocha
Conversation
JustinBeckwith
approved these changes
Nov 15, 2018
| "scripts": { | ||
| "ava": "ava -T 20s --verbose test/*.test.js ./system-test/*.test.js", | ||
| "cover": "nyc --reporter=lcov --cache ava -T 20s --verbose test/*.test.js ./system-test/*.test.js && nyc report", | ||
| "cover": "nyc --reporter=lcov --cache mocha ./system-test/*.test.js --timeout=60000 && nyc report", |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| mocha: true | ||
| rules: | ||
| node/no-unpublished-require: off | ||
| node/no-unsupported-features: off |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Thank you for replacing the backticks btw :) |
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
=======================================
Coverage 97.67% 97.67%
=======================================
Files 2 2
Lines 344 344
Branches 21 21
=======================================
Hits 336 336
Misses 2 2
Partials 6 6Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes convert all sample tests from ava to mocha #2865 (it's a good idea to open an issue first for discussion)