Skip to content
This repository was archived by the owner on Oct 17, 2023. It is now read-only.

refactor(samples): convert sample tests from ava to mocha#171

Merged
JustinBeckwith merged 2 commits intogoogleapis:masterfrom
nareshqlogic:sample_ava_to_mocha
Nov 15, 2018
Merged

refactor(samples): convert sample tests from ava to mocha#171
JustinBeckwith merged 2 commits intogoogleapis:masterfrom
nareshqlogic:sample_ava_to_mocha

Conversation

@nareshqlogic
Copy link
Copy Markdown
Contributor

Fixes convert all sample tests from ava to mocha #2865 (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 15, 2018
@JustinBeckwith JustinBeckwith changed the title Sample ava to mocha refactor(samples): convert sample tests from ava to mocha Nov 15, 2018
Comment thread samples/package.json
"scripts": {
"ava": "ava -T 20s --verbose test/*.test.js ./system-test/*.test.js",
"cover": "nyc --reporter=lcov --cache ava -T 20s --verbose test/*.test.js ./system-test/*.test.js && nyc report",
"cover": "nyc --reporter=lcov --cache mocha ./system-test/*.test.js --timeout=60000 && nyc report",

This comment was marked as spam.

mocha: true
rules:
node/no-unpublished-require: off
node/no-unsupported-features: off

This comment was marked as spam.

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 15, 2018
@JustinBeckwith
Copy link
Copy Markdown
Contributor

Thank you for replacing the backticks btw :)

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 15, 2018
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 15, 2018

Codecov Report

Merging #171 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #171   +/-   ##
=======================================
  Coverage   97.67%   97.67%           
=======================================
  Files           2        2           
  Lines         344      344           
  Branches       21       21           
=======================================
  Hits          336      336           
  Misses          2        2           
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f6bcd9...52673c2. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit c41b1e2 into googleapis:master Nov 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants