chore: De-hardcoded model parameter defaults#2374
Closed
copybara-service[bot] wants to merge 0 commit into
Closed
Conversation
product-auto-label
Bot
added
size: m
copybara-service
Bot
force-pushed
the
copybara_550113719
branch
from
83e193f to
1331c0c
Compare
copybara-service
Bot
force-pushed
the
copybara_550113719
branch
from
1331c0c to
73836bf
Compare
copybara-service
Bot
force-pushed
the
copybara_550113719
branch
from
73836bf to
40f3e41
Compare
product-auto-label
Bot
added
size: u
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: De-hardcoded model parameter defaults
Model interface classes support different models that might have different defaults for their parameters. SDK should not hardcode these parameters by default, letting the user to either use the model's defaults or explicitly override them.
There was a recent similar case where the tuning parameter defaults were different for different tuning methods.