fix: using location and project parsed from resource name#2788
Closed
racinmat wants to merge 1 commit intogoogleapis:mainfrom
Closed
fix: using location and project parsed from resource name#2788racinmat wants to merge 1 commit intogoogleapis:mainfrom
racinmat wants to merge 1 commit intogoogleapis:mainfrom
Conversation
product-auto-label
Bot
added
size: xs
sasha-gitg
reviewed
Oct 9, 2023
| self.resource_name, | ||
| location=location, | ||
| project=project, | ||
| location=location or self.location, |
Member
There was a problem hiding this comment.
Thank you for the contribution! Please update the unit tests to test this change.
sasha-gitg
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
racinmat
force-pushed
the
versioning-registry
branch
from
3f6904d to
6d79bd0
Compare
Contributor
|
Closing due to inactivity. |
Author
|
I am using windows and I was not able to run the tests locally. Is there a simple way how to run them? |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: using location and project parsed from resource name if not provided explicitly
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Note: do not merge your PR from GitHub. Adding the "ready to pull" label is the final step in the review process.
After approvals, the changes in your PR will be committed to the
mainbranch and this PR will be closed.Fixes #2608 🦕
The whole problem is described in the issue.
I do not have rights to add labels, could you please label this PR as
hacktoberfest-accepted?Thanks.