Skip to content

chore: GenAI SDK client - remove unused evals method #6124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2025
+0 −13
Merged

chore: GenAI SDK client - remove unused evals method #6124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions tests/unit/vertexai/genai/test_evals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,12 +152,6 @@ def setup_method(self):
)
self.client = vertexai.Client(project=_TEST_PROJECT, location=_TEST_LOCATION)

@pytest.mark.usefixtures("google_auth_mock")
def test_eval_run(self):
test_client = vertexai.Client(project=_TEST_PROJECT, location=_TEST_LOCATION)
with pytest.raises(NotImplementedError):
test_client.evals.run()

@pytest.mark.usefixtures("google_auth_mock")
@mock.patch.object(client.Client, "_get_api_client")
@mock.patch.object(evals.Evals, "batch_evaluate")
Expand Down
7 changes: 0 additions & 7 deletions vertexai/_genai/evals.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -882,13 +882,6 @@ def _get_evaluation_item(
self._api_client._verify_response(return_value)
return return_value

def run(self) -> types.EvaluateInstancesResponse:
"""Evaluates an instance of a model.

This should eventually call _evaluate_instances()
"""
raise NotImplementedError()

def evaluate_instances(
self,
*,
Expand Down
Loading