Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

docs: add samples for accounts.search_change_history_events() method #137

Merged
merged 24 commits into from
Oct 7, 2021

Conversation

ikuleshov
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ikuleshov ikuleshov requested a review from a team as a code owner September 29, 2021 23:10
@snippet-bot
Copy link

snippet-bot bot commented Sep 29, 2021

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: analyticsadmin Issues related to the googleapis/python-analytics-admin API. samples Issues that are directly related to samples. labels Sep 29, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 29, 2021
@ikuleshov
Copy link
Contributor Author

I see Lint is failing due to missing annotations. I cannot find any examples of the existing API samples using samples and, honestly, the overzealous use of annotations can easily make snippets less readable. I wonder when this requirement was introduced and should it be enforced? Also, this PR adds new files and is not intended to change the formatting/annotation of existing code..

@parthea
Copy link
Contributor

parthea commented Sep 30, 2021

I've removed the strict lint in 79093d1 in #129 . Please can you take a look?

@parthea parthea merged commit c299b37 into googleapis:main Oct 7, 2021
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: analyticsadmin Issues related to the googleapis/python-analytics-admin API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants