This repository was archived by the owner on Dec 31, 2023. It is now read-only.
feat: add UpdateConversionEvent method to the Admin API v1 beta#375
Merged
vchudnov-g merged 2 commits intomainfrom Aug 23, 2023
Merged
feat: add UpdateConversionEvent method to the Admin API v1 beta#375vchudnov-g merged 2 commits intomainfrom
UpdateConversionEvent method to the Admin API v1 beta#375vchudnov-g merged 2 commits intomainfrom
Conversation
feat: add the `counting_method` field to the `ConversionEvent` type feat: add the `ConversionCountingMethod` enum feat: add the `ITEM` option to the `DimensionScope` enum feat: make the field `default_uri` of `WebStreamData` mutable fix!: add the missing `REQUIRED` annotation to the `update_mask` field of `UpdateMeasurementProtocolSecretRequest` PiperOrigin-RevId: 559470845 Source-Link: googleapis/googleapis@751dfcf Source-Link: https://github.com/googleapis/googleapis-gen/commit/d2ef8190576bce8ea3c45ad9dd86c08533c36371 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDJlZjgxOTA1NzZiY2U4ZWEzYzQ1YWQ5ZGQ4NmMwODUzM2MzNjM3MSJ9
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
vchudnov-g
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat: add
UpdateConversionEventmethod to the Admin API v1 betafeat: add the
counting_methodfield to theConversionEventtypefeat: add the
ConversionCountingMethodenumfeat: add the
ITEMoption to theDimensionScopeenumfeat: make the field
default_uriofWebStreamDatamutablefix: add the missing
REQUIREDannotation to theupdate_maskfield ofUpdateMeasurementProtocolSecretRequestEND_COMMIT_OVERRIDE
PiperOrigin-RevId: 559470845
Source-Link: googleapis/googleapis@751dfcf
Source-Link: https://github.com/googleapis/googleapis-gen/commit/d2ef8190576bce8ea3c45ad9dd86c08533c36371
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDJlZjgxOTA1NzZiY2U4ZWEzYzQ1YWQ5ZGQ4NmMwODUzM2MzNjM3MSJ9