This repository was archived by the owner on Mar 12, 2025. It is now read-only.
Conversation
ohmayr
approved these changes
Nov 6, 2024
|
|
||
| install_command = ["-e", f"{working_dir}/{downstream_dir}"] | ||
| if prerelease: | ||
| session.install("-e", f"{working_dir}/{downstream_dir}") |
There was a problem hiding this comment.
Why not move it outside the conditional logic like before and have a single session.install towards the end. It seems to be that we probably just want to remove install_command.extend(["--no-deps"])
Contributor
Author
There was a problem hiding this comment.
The install_prerelease_dependencies has several install commands where we install pre-release versions of dependencies. I wanted to make sure to install the dependencies of the downstream client before upgrading to the pre-release versions of dependencies. If we did this at the end , we may downgrade the pre-release dependencies
parthea
added a commit
to googleapis/python-grpc-google-iam-v1
that referenced
this pull request
Dec 23, 2024
parthea
added a commit
to googleapis/python-grpc-google-iam-v1
that referenced
this pull request
Dec 27, 2024
* chore(python): update dependencies in .kokoro/docker/docs Source-Link: googleapis/synthtool@e808c98 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8e3e7e18255c22d1489258d0374c901c01f9c4fd77a12088670cd73d580aa737 * Add python 3.13 constraints file * Add python 3.13 to setup.py * Add python 3.13 to unittest.yml * Add python 3.13 to noxfile * Add flaky to test dependencies * See googleapis/python-api-common-protos#257 * lint * fix build * fix build * coverage * coverage --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the error seen in #256 which occurred because opentelemetry was added as a direct dependency of
google-cloud-pubsuband we run tests against pubsub via this codepython-api-common-protos/noxfile.py
Lines 175 to 176 in f30115b