Skip to content
This repository was archived by the owner on Apr 1, 2026. It is now read-only.

feat: Include remote_function name in generated cloud function name#2388

Closed
TrevorBergeron wants to merge 4 commits intomainfrom
cf_name
Closed

feat: Include remote_function name in generated cloud function name#2388
TrevorBergeron wants to merge 4 commits intomainfrom
cf_name

Conversation

@TrevorBergeron
Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 16, 2026
@TrevorBergeron TrevorBergeron marked this pull request as ready for review January 16, 2026 23:06
@TrevorBergeron TrevorBergeron requested a review from a team as a code owner January 16, 2026 23:06
@TrevorBergeron TrevorBergeron requested a review from a team January 16, 2026 23:06
Copy link
Copy Markdown
Contributor

@jialuoo jialuoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following tests failed in e2e, please fix them.

FAILED tests/system/large/functions/test_remote_function.py::test_remote_function_with_explicit_name
FAILED tests/system/large/functions/test_remote_function.py::test_remote_function_with_explicit_name_reuse
FAILED tests/system/large/functions/test_remote_function.py::test_remote_function_w_context_manager_named[session-constructor]
FAILED tests/system/large/functions/test_remote_function.py::test_remote_function_named_perists_w_session_cleanup
FAILED tests/system/large/functions/test_remote_function.py::test_remote_function_w_context_manager_named[connect-method]
FAILED tests/system/large/functions/test_remote_function.py::test_remote_function_clean_up_by_session_id

tswast
tswast previously approved these changes Jan 16, 2026
@chalmerlowe
Copy link
Copy Markdown

Migration Notice: This library is moving to the google-cloud-python monorepo soon.

We closed this PR due to inactivity to ensure a clean migration. Please re-open this work in the new monorepo once the migration is complete!

@chalmerlowe chalmerlowe closed this Mar 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants