feat: Suppress redundant "Completed" status in progress callback #2419
+142
−213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
product-auto-label
bot
added
size: l
bigframes/formatting_helpers.py
Outdated
Comment on lines
207
to
210
| display.update_display( | ||
| display.HTML(""), | ||
| display_id=current_display_id, | ||
| ) |
Contributor
There was a problem hiding this comment.
do we want to display anything at all? with this we still get a blank line?
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion, I have removed the else block to prevent the blank line.
shuoweil
force-pushed
the
shuowei-anywidget-complete-status-update
branch
from
f9a1197 to
876fb79
Compare
TrevorBergeron
approved these changes
Feb 3, 2026
shuoweil
added a commit
that referenced
this pull request
Feb 4, 2026
This PR refines the visual feedback provided during operation progress. Specifically, it prevents the display of a standalone "✅ Completed." message and green checkmark when no query execution information (like slot time or bytes processed) is available. This often occurs during metadata-only operations or cached results where the "Completed" status is redundant. Fixes #<479944983> 🦕
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refines the visual feedback provided during operation progress. Specifically, it prevents the display of a standalone "✅ Completed." message and green checkmark when no query execution information (like slot time or bytes processed) is available. This often occurs during metadata-only operations or cached results where the "Completed" status is redundant.
Fixes #<479944983> 🦕