feat: remove bqsql magic to make that name available for bigframes#210
feat: remove bqsql magic to make that name available for bigframes#210
Conversation
Removes the `%%bqsql` magic alias, including its registration in `__init__.py`, references in documentation (README.rst, magics.rst, docstrings), and unit tests. This magic was an alias for `%%bigquery`. Co-authored-by: tswast <247555+tswast@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary of ChangesHello @tswast, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the BigQuery IPython magics by completely removing the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly removes the %%bqsql magic alias across the codebase, including its registration, documentation, and tests. The changes are straightforward and well-executed. I've added one minor suggestion in the test file to improve code style and readability after the removal of a parameter.
Removes the `%%bqsql` magic alias, including its registration in `__init__.py`, references in documentation (README.rst, magics.rst, docstrings), and unit tests. This magic was an alias for `%%bigquery`. Co-authored-by: tswast <247555+tswast@users.noreply.github.com>
|
googleapis/python-bigquery-dataframes#2395 to add this in bigframes |
Removes the
%%bqsqlmagic alias.Changes:
ipython.register_magic_functioncall forbqsqlinbigquery_magics/__init__.py.%%bqsqlreferences frombigquery_magics/bigquery.pydocstring.bqsqlfromtest_extension_loadparametrization intests/unit/bigquery/test_bigquery.py.%%bqsqlreferences and examples fromREADME.rstanddocs/magics.rst.PR created automatically by Jules for task 18023458691533748703 started by @tswast