Skip to content

Conversation

@jonathansp
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 12, 2017

Codecov Report

Merging #87 into master will decrease coverage by 45.4%.
The diff coverage is 27.27%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #87       +/-   ##
===========================================
- Coverage   73.61%   28.21%   -45.41%     
===========================================
  Files           4        4               
  Lines        1554     1563        +9     
===========================================
- Hits         1144      441      -703     
- Misses        410     1122      +712
Impacted Files Coverage Δ
pandas_gbq/tests/test_gbq.py 27.8% <16.66%> (-55.2%) ⬇️
pandas_gbq/gbq.py 19.66% <40%> (-55.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79c9067...b4ba5cf. Read the comment docs.

Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonathansp ! Please could you also create an entry in the changelog? https://github.com/pydata/pandas-gbq/blob/master/docs/source/changelog.rst

As an example,

- Environment variable ``PANDAS_GBQ_CREDENTIALS_FILE`` can now be used to override the default location where the BigQuery user account credentials are stored. (:issue:`86`)

getting user credentials.
getting user credentials. A file named bigquery_credentials.dat will
be created in current dir. You can also set PANDAS_GBQ_CREDENTIALS_FILE
environment variable so as to define a specific path to storage this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

storage->store

@jonathansp
Copy link
Contributor Author

Done.

Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonathansp !

@parthea parthea merged commit dbfb4e9 into googleapis:master Sep 13, 2017
@jonathansp
Copy link
Contributor Author

Thanks, @parthea, we really appreciate your work. Do you have a release plan for this change?

@andrelu
Copy link

andrelu commented Sep 18, 2017

Thanks, @parthea, we really appreciate your work. Do you have a release plan for this change?
+up

@parthea
Copy link
Contributor

parthea commented Sep 19, 2017

@jonathansp I'm hoping to create a new release once #83 is merged (pending approval). It would be great to get your feedback on that PR.

In the interim while we are preparing for the next release, you could install the latest master using:
pip install https://github.com/pydata/pandas-gbq/archive/master.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants