Skip to content

Conversation

@dimkonko
Copy link
Contributor

Use TableReference instead.

Issue: #58

Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@tswast
Copy link
Collaborator

tswast commented Jun 24, 2020

Hmmm. Not sure why the tests aren't running against the PR.

@tswast
Copy link
Collaborator

tswast commented Jul 15, 2020

Tests pass locally:

$ gh pr checkout 59

$ pytest test
====================================== test session starts =======================================
platform darwin -- Python 3.6.10, pytest-3.2.2, py-1.9.0, pluggy-0.4.0
rootdir: /Users/swast/src/pybigquery, inifile: setup.cfg
collected 63 items

test/test_dialect_types.py .
test/test_parse_url.py ....................................
test/test_sqlalchemy_bigquery.py ...
.
.
.
=================================== 63 passed in 69.75 seconds ===================================

Thank you @dimkonko for the contribution!

@tswast tswast merged commit 2a41ed7 into googleapis:master Jul 15, 2020
@dimkonko dimkonko deleted the fix_dataset_deprecation_warning branch July 24, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants