Skip to content

Compile array columns. #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tswast merged 1 commit into from
Nov 18, 2020
Merged

Compile array columns. #64

tswast merged 1 commit into from
Nov 18, 2020

Conversation

@jmcarp
Copy link
Contributor

@jmcarp jmcarp commented Sep 6, 2020 •
edited
Loading

Generate bigquery ddl for array columns and add tests.

cc @tswast @mxmzdlv

@jmcarp
Copy link
Contributor Author

jmcarp commented Nov 17, 2020

Ping @tswast @mxmzdlv. Do you have time to look at this? It's a very small change.

tswast
tswast approved these changes Nov 18, 2020
View reviewed changes
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! Thank you.

@tswast
Copy link
Collaborator

tswast commented Nov 18, 2020

Confirmed locally that tests are passing.

@tswast tswast merged commit db971fb into googleapis:master Nov 18, 2020
@JacobHayes JacobHayes mentioned this pull request Jan 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswast tswast tswast approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmcarp @tswast