Add Flake8 check plugin to pytest. Fix code style #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswast
approved these changes
Oct 2, 2020
Collaborator
tswast
left a comment
tswast
left a comment
There was a problem hiding this comment.
Thanks for doing this!
Can you share the command-line output of running this lint test locally?
Contributor
Author
|
@tswast there is no output for flake8 part when there is no issues. |
Contributor
Author
|
@tswast Could you please merge? |
tswast
reviewed
Nov 18, 2020
| table.c.string, | ||
| col_concat, | ||
| func.avg(table.c.integer), | ||
| func.sum(case([(table.c.boolean == True, 1)], else_=0)) |
Collaborator
There was a problem hiding this comment.
FYI: I was getting a test failure for "is True". Changing to compare with equality and a sqlalchemy literal fixed the test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.