Skip to content
This repository was archived by the owner on Mar 16, 2026. It is now read-only.

test: update system test fixtures to create necessary tables#96

Merged
tswast merged 2 commits intogoogleapis:masterfrom
tswast:issue94-test_sqlalchemy_bigquery
Mar 24, 2021
Merged

test: update system test fixtures to create necessary tables#96
tswast merged 2 commits intogoogleapis:masterfrom
tswast:issue94-test_sqlalchemy_bigquery

Conversation

@tswast
Copy link
Copy Markdown
Contributor

@tswast tswast commented Mar 24, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #94 🦕

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 24, 2021
@tswast
Copy link
Copy Markdown
Contributor Author

tswast commented Mar 24, 2021

Note: I still expect the tests to fail due to the docs session failing: #90

@tswast
Copy link
Copy Markdown
Contributor Author

tswast commented Mar 24, 2021

As expected:

nox > Ran multiple sessions:
nox > * unit-3.6: success
nox > * unit-3.7: success
nox > * unit-3.8: success
nox > * unit-3.9: success
nox > * system-3.8: success
nox > * cover: success
nox > * lint: success
nox > * lint_setup_py: success
nox > * blacken: success
nox > * docs: failed

@tswast tswast merged commit e9d66fb into googleapis:master Mar 24, 2021
@tswast tswast deleted the issue94-test_sqlalchemy_bigquery branch March 24, 2021 21:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests.system.test_sqlalchemy_bigquery: many tests failed

1 participant