Skip to content
This repository was archived by the owner on Nov 12, 2025. It is now read-only.

build: fix release build#59

Merged
busunkim96 merged 4 commits into
masterfrom
fix-release
Sep 16, 2020
Merged

build: fix release build#59
busunkim96 merged 4 commits into
masterfrom
fix-release

Conversation

@busunkim96
Copy link
Copy Markdown
Contributor

@busunkim96 busunkim96 commented Sep 16, 2020

Switch to release publish bot for reporting status back to GitHub release PRs.

@busunkim96 busunkim96 requested review from a team and plamut September 16, 2020 14:54
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 16, 2020
@busunkim96 busunkim96 changed the title fix: fix release build build: fix release build Sep 16, 2020
@tswast tswast added the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 16, 2020
@plamut
Copy link
Copy Markdown
Contributor

plamut commented Sep 16, 2020

Now this will be handy, thanks!

P.S.: I'm not really familiar with Kokoro config and don't have insight into internal logs, thus I cannot really say in advance whether it will fix the release build, sorry, :)

@plamut plamut removed their request for review September 16, 2020 15:07
@plamut plamut added the automerge Merge the pull request once unit tests and other checks pass. label Sep 16, 2020
@busunkim96 busunkim96 removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 16, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 16, 2020
@plamut
Copy link
Copy Markdown
Contributor

plamut commented Sep 16, 2020

Seems like the build failed, but I cannot see the logs, since not all checks have finished yet.

Edit: Aha, making a script runnable is a good idea. 😆

@busunkim96
Copy link
Copy Markdown
Contributor Author

Confirmed by running the release build on my branch that this combination of files is sufficient https://source.cloud.google.com/results/invocations/c20fabd9-c754-49b7-9bec-dc91f3f1b3ba/targets/cloud-devrel%2Fclient-libraries%2Fpython%2Fgoogleapis%2Fpython-bigquery-storage%2Frelease%2Frelease/log (release itself failed because version 1.0.0 already exists)

@plamut
Copy link
Copy Markdown
Contributor

plamut commented Sep 16, 2020

Uploading the wheel 1.0.0 failed, is there something hardcoded such as the name or the version?

Uploading distributions to https://upload.pypi.org/legacy/
Uploading google_cloud_bigquery_storage-1.0.0-py2.py3-none-any.whl
...
HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
File already exists. See https://pypi.org/help/#file-name-reuse for more information.

@plamut
Copy link
Copy Markdown
Contributor

plamut commented Sep 16, 2020

@busunkim96 Does this mean we can (force) merge this and then create a new release PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants