Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

chore: use google-cloud-testutils in noxfile#101

Merged
plamut merged 4 commits intomasterfrom
busunkim96-patch-2
May 13, 2020
Merged

chore: use google-cloud-testutils in noxfile#101
plamut merged 4 commits intomasterfrom
busunkim96-patch-2

Conversation

@busunkim96
Copy link
Copy Markdown
Contributor

@busunkim96 busunkim96 commented May 11, 2020

This needs to be installed from PyPI for internal VPCSC tests.

@busunkim96 busunkim96 requested a review from plamut May 11, 2020 19:36
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 11, 2020
Copy link
Copy Markdown
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

The lint error has nothing to do with this PR, it complains about a variable name in the line last modified almost 10 months ago (even on master).

Has the flake8 check changed due to an update or a config change?

Update: I opened a fix for it - #103.

@plamut plamut merged commit 834e2c0 into master May 13, 2020
@tswast tswast deleted the busunkim96-patch-2 branch July 27, 2021 21:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants