Feat: adding async support for notebooks magics #1182
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed language issues. Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #<issue_number_goes_here> 🦕
…t_bqml_magics updating
…t_bqml_magics updating branch to main
product-auto-label
bot
added
the
api: bigquery
shollyman
reviewed
Apr 14, 2022
Contributor
shollyman
left a comment
shollyman
left a comment
There was a problem hiding this comment.
Unclear on the completeness here, given the TODO comments and test failures.
| Args: | ||
| line (str): "%%bigquery" followed by arguments as required | ||
| query (str): SQL query to run | ||
| cell_body (str): SQL query or other command to run TODO |
Contributor
Author
There was a problem hiding this comment.
Will update soon to resolve test failures - the TODOs are typos/oversights.
brijk7
reviewed
Apr 19, 2022
…t_bqml_magics updating local
…ery into feat_bqml_magics merging remote and local
brijk7
reviewed
Aug 25, 2022
brijk7
reviewed
Aug 26, 2022
|
|
||
| if args.send_long_job: | ||
| if args.destination_var: | ||
| IPython.get_ipython().push({args.destination_var: result}) |
There was a problem hiding this comment.
execution can reach here while job thread is still running in the async case. i think you'd want to refactor this so that there is one copy of the result post-processing code, and it gets called in both scenarios (sync and async) after completion of the job (maybe as a separate function).
…ery into feat_bqml_magics merge local and remote
…ery into feat_bqml_magics merge local and remote
Contributor
|
We're moving the magics code to a new repo. Closing this and tracking support here: googleapis/python-bigquery-magics#17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: