This repository was archived by the owner on Mar 6, 2026. It is now read-only.
chore: restrict rsa version to <=4.0 for Python 2.7 compatibility#135
Merged
plamut merged 4 commits intogoogleapis:masterfrom Jun 16, 2020
Merged
chore: restrict rsa version to <=4.0 for Python 2.7 compatibility#135plamut merged 4 commits intogoogleapis:masterfrom
rsa version to <=4.0 for Python 2.7 compatibility#135plamut merged 4 commits intogoogleapis:masterfrom
Conversation
4 tasks
Contributor
Author
I'm not sure what that is, happens when commands in virtualenvs are run, hopefully a restart will make the CI checks green again. |
Contributor
|
bad day for python releases. looks like the new breakage here is in virtualenv |
Contributor
Contributor
Author
|
@HemangChothani Thanks for the update! In theory the change should not be needed, just a version bump of the I would thus play it safe and be explicit about this, but I will borrow the fix from |
shollyman
approved these changes
Jun 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #134.
This PR assures that too new a version of the
rsadependency does not break the library's Python 2.7 compatibility.That version is already two years old, though, and it represents a yet another reason to start dropping Python 2.7 (and 3.5) support, too.
PR checklist