Skip to content

chore(deps): remove redundant dependencies #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HemangChothani merged 3 commits into from
Jul 15, 2020
Merged

chore(deps): remove redundant dependencies #164

HemangChothani merged 3 commits into from
Jul 15, 2020

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Jul 13, 2020

Fixes #158

@HemangChothani HemangChothani requested a review from plamut July 13, 2020 13:01
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 13, 2020
@plamut
Copy link
Contributor

plamut commented Jul 13, 2020 •
edited
Loading

I believe we also need to bump the api-core version to benefit from the most recent version pins in it?

For example, the rsa pins have last been tightened in google-auth in version 1.17.2, but the latter was only bumped in api-core version 1.21.0.

(we currently pin api-core to >= 1.15.0)

@HemangChothani HemangChothani merged commit 08c12c5 into googleapis:master Jul 15, 2020
@shollyman shollyman mentioned this pull request Aug 3, 2020
Closed
@tswast
Copy link
Contributor

tswast commented Oct 1, 2020

Ummm, protobuf was not redundant. It's needed for the BQML files in the google.cloud.bigquery_v2 package.

@tswast
Copy link
Contributor

tswast commented Oct 1, 2020

Hmm... I guess that it's included in google-api-core, but somehow the minimum version isn't making it's way to some of our downstream wrappers. ibis-project/ibis#2413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@plamut plamut plamut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove redundant dependencies

4 participants

@HemangChothani @plamut @tswast @googlebot