Skip to content

Conversation

@Linchin
Copy link
Contributor

@Linchin Linchin commented May 29, 2024

Adds a warning message if storage client is not used because module is not found.

Fixes #1931 🦕

@Linchin Linchin requested review from a team as code owners May 29, 2024 20:22
@Linchin Linchin requested a review from GaoleMeng May 29, 2024 20:22
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery API. labels May 29, 2024
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two preferences that help future me better understand this test code at a glance.

chalmerlowe and others added 3 commits May 30, 2024 09:44
Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
@Linchin Linchin enabled auto-merge (squash) May 30, 2024 19:34
@Linchin Linchin merged commit 5f85e2e into googleapis:main May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a warning message when BigQuery Storage API is not used despite create_bqstorage_client=True

2 participants