chore(revert): revert preventing normalization #625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandhlee
requested review from
a team and
tswast
and removed request for
a team
product-auto-label
bot
added
the
api: bigquery
google-cla
bot
added
the
cla: yes
plamut
reviewed
Apr 26, 2021
Contributor
plamut
left a comment
plamut
left a comment
There was a problem hiding this comment.
Why do we need a revert, did the original change cause some sort of regression?
Looks good otherwise.
Contributor
It forces folks to use a much newer version of pip/setuptools than we actually want to require. The docs team will workaround the version parsing issue in a different way. |
tswast
approved these changes
Apr 26, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverts previous commit for preventing normalization of versioning
Reverts #611.