Skip to content
This repository was archived by the owner on Mar 6, 2026. It is now read-only.

docs(samples): deprecate client.dataset method#98

Merged
steffnay merged 7 commits intogoogleapis:masterfrom
steffnay:dep-dataset
May 11, 2020
Merged

docs(samples): deprecate client.dataset method#98
steffnay merged 7 commits intogoogleapis:masterfrom
steffnay:dep-dataset

Conversation

@steffnay
Copy link
Copy Markdown
Contributor

@steffnay steffnay commented May 7, 2020

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

🦕🐢

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 7, 2020
Copy link
Copy Markdown
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the snippets look great.

There's one thing here of concern, and that's the project field of the client. It's not currently a property, should it be? I believe in some cases the project is derived indirectly (e.g. from credentials), and we should either try to resolve this, or throw an error that the project isn't set explicitly.

@steffnay steffnay merged commit 5ba6397 into googleapis:master May 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants