This repository was archived by the owner on Mar 6, 2026. It is now read-only.
docs(samples): deprecate client.dataset method#98
Merged
steffnay merged 7 commits intogoogleapis:masterfrom May 11, 2020
Merged
docs(samples): deprecate client.dataset method#98steffnay merged 7 commits intogoogleapis:masterfrom
steffnay merged 7 commits intogoogleapis:masterfrom
Conversation
stephaniewang526
approved these changes
May 7, 2020
shollyman
reviewed
May 11, 2020
Contributor
shollyman
left a comment
There was a problem hiding this comment.
The changes to the snippets look great.
There's one thing here of concern, and that's the project field of the client. It's not currently a property, should it be? I believe in some cases the project is derived indirectly (e.g. from credentials), and we should either try to resolve this, or throw an error that the project isn't set explicitly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦕🐢