-
Notifications
You must be signed in to change notification settings - Fork 6
chore: librarian release pull request: 20251215T132415Z #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request is an automated chore initiated by the Librarian CLI to prepare for the release of Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is an automated release for version 1.5.0 of db-dtypes, which adds support for Python 3.14. The changes correctly update the version in the project files. However, I've found some issues in the auto-generated CHANGELOG.md file where the links for the new release are incorrect, pointing to the wrong repository and using an incorrect base version for comparison. This appears to be due to the release tool using a stale version from .librarian/state.yaml. My review includes a suggestion to fix these links.
| ## [1.5.0](https://github.com/googleapis/google-cloud-python/compare/db-dtypes-v1.4.3...db-dtypes-v1.5.0) (2025-12-15) | ||
|
|
||
|
|
||
| ### Features | ||
|
|
||
| * Add support for Python 3.14 (#380) ([c164a47be909203606cf982d6f0becc6c8efdb09](https://github.com/googleapis/google-cloud-python/commit/c164a47be909203606cf982d6f0becc6c8efdb09)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generated links in this changelog entry appear to be incorrect.
- The repository in the URLs is
google-cloud-python, but it should bepython-db-dtypes-pandas. - The version comparison in the release link is against
v1.4.3, but the previous version was1.4.4(as seen indb_dtypes/version.pybefore this change). - The tag format
db-dtypes-vX.Y.Zis inconsistent with previous entries which usevX.Y.Z.
I've suggested a fix that aligns with the previous changelog entries.
| ## [1.5.0](https://github.com/googleapis/google-cloud-python/compare/db-dtypes-v1.4.3...db-dtypes-v1.5.0) (2025-12-15) | |
| ### Features | |
| * Add support for Python 3.14 (#380) ([c164a47be909203606cf982d6f0becc6c8efdb09](https://github.com/googleapis/google-cloud-python/commit/c164a47be909203606cf982d6f0becc6c8efdb09)) | |
| ## [1.5.0](https://github.com/googleapis/python-db-dtypes-pandas/compare/v1.4.4...v1.5.0) (2025-12-15) | |
| ### Features | |
| * Add support for Python 3.14 (#380) ([c164a47be909203606cf982d6f0becc6c8efdb09](https://github.com/googleapis/python-db-dtypes-pandas/commit/c164a47be909203606cf982d6f0becc6c8efdb09)) |
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release.
Librarian Version: v0.7.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620
db-dtypes: 1.5.0
1.5.0 (2025-12-15)
Features