feat: parsed candidate can be a list#886
Open
Vandivier wants to merge 5 commits intogoogleapis:mainfrom
Open
Conversation
Author
|
@sararob @MarkDaoust thoughts? |
Collaborator
|
Thanks for the ping.
|
Author
|
@MarkDaoust updated! |
Collaborator
|
@Vandivier |
Author
|
@janasangeetha done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #882
this code functionally works as of 1.16.1, and mypy accepts it:
but, I don't want to
cast. Casting reduces my confidence in my unit tests.I'm really uncomfortable at unit test time, where I need
response.parsedto be mocked with a type not officially supported in the library.So, to avoid casting, let's explicitly support the
list[pydantic.BaseModel]!