Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no duplicate logs on GCF or GAE #209

Merged
merged 28 commits into from Mar 15, 2021
Merged

fix: no duplicate logs on GCF or GAE #209

merged 28 commits into from Mar 15, 2021

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Mar 9, 2021

Previously, the library would send duplicate logs on certain environments, due to built-in logging handlers that would write to standard output. This PR removes those extra handlers as part of the setup_logging function now when detected.

Also adds a test to ensure all platforms receive exactly one for each log

fixes #184

@product-auto-label product-auto-label bot added the api: logging label Mar 9, 2021
@google-cla google-cla bot added the cla: yes label Mar 9, 2021
@daniel-sanche daniel-sanche marked this pull request as ready for review Mar 11, 2021
@daniel-sanche daniel-sanche requested review from as code owners Mar 11, 2021
@daniel-sanche daniel-sanche marked this pull request as draft Mar 11, 2021
@daniel-sanche daniel-sanche changed the title [DRAFT] tests: added test checking for duplicates fix: no duplicate logs on GCF or GAE Mar 11, 2021
@daniel-sanche daniel-sanche marked this pull request as ready for review Mar 11, 2021
@daniel-sanche daniel-sanche added the kokoro:force-run label Mar 12, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Mar 12, 2021
0xSage
0xSage approved these changes Mar 15, 2021
@daniel-sanche daniel-sanche merged commit 37e6c8e into master Mar 15, 2021
12 of 15 checks passed
@daniel-sanche daniel-sanche deleted the test-duplicates branch Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants