Query repeated structured properties. #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
added 2 commits
June 5, 2019 16:09
cguardia
approved these changes
Jun 6, 2019
Contributor
cguardia
left a comment
cguardia
left a comment
There was a problem hiding this comment.
Looks good. Just a couple of doc typos.
src/google/cloud/ndb/query.py
Outdated
| This query should find any squad with a member named "Joe" whose age is 24 | ||
| and rank is 5. | ||
| Datastore, on its own, can find all squads a with a team member named Joe, |
Contributor
There was a problem hiding this comment.
Typo: should be "all squads with".
src/google/cloud/ndb/query.py
Outdated
| Datastore, on its own, can find all squads a with a team member named Joe, | ||
| or a team member whose age is 24, or whose rank is 5, but it can't be | ||
| queried for all 3 in a single subentity. This predicate must be applied | ||
| client side, therefore, to limit results to entities where the all keys |
Contributor
There was a problem hiding this comment.
Should be "where all the keys".
src/google/cloud/ndb/query.py
Outdated
| (e.g. "members"). | ||
| match_keys (list[str]): Property names to check on the subentities | ||
| being queried (e.g. ["name", "age", "rank"]). | ||
| entity_pb (entity_pb2.Entity): A partial entity prototocol buffer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.