Skip to content

Release python-ndb 0.0.1 #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrewsg merged 3 commits into from
Jun 18, 2019
Merged

Release python-ndb 0.0.1 #109

andrewsg merged 3 commits into from
Jun 18, 2019

Conversation

@crwilcox
Copy link
Collaborator

@crwilcox crwilcox commented Jun 11, 2019

No description provided.

@crwilcox crwilcox requested a review from andrewsg as a code owner June 11, 2019 23:51
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 11, 2019
@crwilcox crwilcox force-pushed the release-python-ndb-0.0.1 branch from 78e4c63 to 6fd7a59 Compare June 11, 2019 23:51
@crwilcox crwilcox mentioned this pull request Jun 11, 2019
Closed
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 12, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 12, 2019
@chrisrossi
Copy link
Contributor

chrisrossi commented Jun 12, 2019

I have made #111 to address the docs build failure inherited from master.

The unittest failures are due to the version in src/google/cloud/ndb/__init__.py not matching the version in setup.py and is best addressed by @crwilcox in this PR.

andrewsg
andrewsg approved these changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here look good; merge after tests pass ofc. Thanks!

@andrewsg andrewsg merged commit 06193f6 into master Jun 18, 2019
@busunkim96
Copy link
Contributor

busunkim96 commented Jun 18, 2019

I think you'll need to carry this release over the finish line manually. @crwilcox

Proper releasetool support for split repositories coming very, very soon, since we're splitting the mono-repo. 😁

@crwilcox
Copy link
Collaborator Author

crwilcox commented Jun 18, 2019

Thanks @busunkim96 I was waiting to see if ✨ magic ✨ happened. Guess I get to do this the old fashioned way :)

@crwilcox
Copy link
Collaborator Author

crwilcox commented Jun 18, 2019

PyPI: https://pypi.org/project/google-cloud-ndb/0.0.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewsg andrewsg andrewsg approved these changes

Assignees

No one assigned

Labels

autorelease: published cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@crwilcox @chrisrossi @busunkim96 @andrewsg @googlebot @yoshi-kokoro