fix: attempt to have fewer transient errors in continuous integration#328
Merged
chrisrossi merged 1 commit intogoogleapis:masterfrom Feb 7, 2020
Merged
Conversation
googlebot
added
the
cla: yes
We have been having more transient errors in the system tests run by Kokoro. This patch: 1) Increased timeout used by `eventually` fixture from 60 seconds to 120 seconds. 2) Randomizes "other namespace", like we were already doing with the primary namespace used by tests. This should make it vanishingly unlikely that a test can have its initial state polluted by a previously run test, as each test will be run in its own namespace. 3) Relaxes the checks for undeleted entities during test cleanup. Instead of a failing assertion, now, we'll just log a warning if there are any leftover entities at the end of a test.
chrisrossi
force-pushed
the
improve-system-tests
branch
from
931efc1 to
e5590e9
Compare
cguardia
approved these changes
Feb 7, 2020
Contributor
cguardia
left a comment
cguardia
left a comment
There was a problem hiding this comment.
Thanks! Using the random namespaces is a good idea.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have been having more transient errors in the system tests run by
Kokoro. This patch:
Increased timeout used by
eventuallyfixture from 60 seconds to 120seconds.
Randomizes "other namespace", like we were already doing with the
primary namespace used by tests. This should make it vanishingly
unlikely that a test can have its initial state polluted by a previously
run test, as each test will be run in its own namespace.
Relaxes the checks for undeleted entities during test cleanup.
Instead of a failing assertion, now, we'll just log a warning if there
are any leftover entities at the end of a test.