You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on May 6, 2026. It is now read-only.
A little bit of background discussion, since even though it's a simple change, the implications are somewhat complicated:
Andrew Gorcester, Tue 5:22 PM
@chris Rossi Earlier I said ABORTED could be retried; I thought better of it and dug a little deeper and it's a bit more complicated than that
From Clem: "the semantics of ABORTED is: "retry at a higher level"
for transactions, this means retrying the complete transaction, not only the Commit RPC"
That suggests that some RPCs could potentially be retried if they're self-contiained but many cannot be, they would need user interaction or code that retries the entire process from the start
Chris Rossi, Yesterday 11:35 AM
Ok. I think NDB has retry for transactions and for individual RPCs. I'll take a closer look and see if I can't tease out a way to apply this to the former and not the latter.
Chris Rossi, Yesterday 4:33 PM
So, I'm poking around, and if we're in a transaction, and we get a retryable error, we already retry the entire transaction. So if we add ABORTED to our list retryable codes, we'll be following the semantics of ABORTED when we're in a transaction. If we're not in a transaction, then we shouldn't see it, would be my guess, so having it in the list shouldn't make any difference one way or the other for non-transactions. Does that seem reasonable?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla: yesThis human has signed the Contributor License Agreement.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #383.