Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

fix: make optimized Query.count() work with the datastore emulator#528

Merged
chrisrossi merged 1 commit into
googleapis:masterfrom
chrisrossi:fix-525
Sep 2, 2020
Merged

fix: make optimized Query.count() work with the datastore emulator#528
chrisrossi merged 1 commit into
googleapis:masterfrom
chrisrossi:fix-525

Conversation

@chrisrossi
Copy link
Copy Markdown
Contributor

The emulator is different enough from the real Datastore to require some
special handling.

Fixes #525

@chrisrossi chrisrossi requested a review from cguardia September 1, 2020 19:30
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 1, 2020
Copy link
Copy Markdown
Contributor

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@product-auto-label product-auto-label Bot added the api: datastore Issues related to the googleapis/python-ndb API. label Sep 2, 2020
The emulator is different enough from the real Datastore to require some
special handling.

Fixes googleapis#525
@chrisrossi chrisrossi merged commit e5df1e3 into googleapis:master Sep 2, 2020
@chrisrossi chrisrossi deleted the fix-525 branch September 2, 2020 13:21
@chrisrossi chrisrossi mentioned this pull request Sep 2, 2020
snarfed added a commit to snarfed/bridgy that referenced this pull request Sep 12, 2020
they fixed the 1.5.1 bug in 1.5.2: googleapis/python-ndb#528

This reverts commit 56f3065.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datastore Issues related to the googleapis/python-ndb API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimized Query.count() hangs with the Datstore Emulator

2 participants