Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

feat: memcached integration#536

Merged
chrisrossi merged 1 commit into
googleapis:masterfrom
chrisrossi:feat-memcache
Sep 14, 2020
Merged

feat: memcached integration#536
chrisrossi merged 1 commit into
googleapis:masterfrom
chrisrossi:feat-memcache

Conversation

@chrisrossi
Copy link
Copy Markdown
Contributor

Mostly just still need to test.

@chrisrossi chrisrossi added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 8, 2020
@chrisrossi chrisrossi requested a review from cguardia September 8, 2020 19:36
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 8, 2020
Copy link
Copy Markdown
Contributor

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great so far.

Comment thread google/cloud/ndb/global_cache.py Outdated
@product-auto-label product-auto-label Bot added the api: datastore Issues related to the googleapis/python-ndb API. label Sep 9, 2020
@chrisrossi chrisrossi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2020
@chrisrossi chrisrossi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 9, 2020
Adds a new `GlobalCache` implementation, `MemcacheCache`, which allows
memcached to be used as a global cache. May be used with a Google
Memorystore, or any configured memcached instance.
@chrisrossi
Copy link
Copy Markdown
Contributor Author

Ok, I have successfully tested this with a test app against an actual Memorystore instance and have squashed my commits. This should be ready to go. Please give it another look before I merge.

@chrisrossi chrisrossi removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 14, 2020
@cguardia
Copy link
Copy Markdown
Contributor

cguardia commented Sep 14, 2020

@chrisrossi it does indeed looks ready to merge.

@chrisrossi chrisrossi changed the title WIP: Initial memcache implementation feat: memcached integration Sep 14, 2020
@chrisrossi chrisrossi merged commit 2bd43da into googleapis:master Sep 14, 2020
@chrisrossi chrisrossi deleted the feat-memcache branch September 14, 2020 21:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datastore Issues related to the googleapis/python-ndb API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants