Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

fix(dependencies): Pin to less than 2.0.0 for google-cloud-datastore#569

Merged
gcf-merge-on-green[bot] merged 2 commits into
masterfrom
crwilcox-patch-2
Nov 11, 2020
Merged

fix(dependencies): Pin to less than 2.0.0 for google-cloud-datastore#569
gcf-merge-on-green[bot] merged 2 commits into
masterfrom
crwilcox-patch-2

Conversation

@crwilcox
Copy link
Copy Markdown
Contributor

@crwilcox crwilcox commented Nov 11, 2020

there are breaking changes in the next major version of datastore and pinning below 2.0.0 will stop those changes from breaking ndb.

Fixes #568

there are breaking changes in the next major version of datastore and pinning below 2.0.0 will stop those changes from breaking ndb.
@crwilcox crwilcox requested a review from andrewsg as a code owner November 11, 2020 17:52
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 11, 2020
@product-auto-label product-auto-label Bot added the api: datastore Issues related to the googleapis/python-ndb API. label Nov 11, 2020
Copy link
Copy Markdown
Contributor

@chrisrossi chrisrossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andrewsg andrewsg added the automerge Merge the pull request once unit tests and other checks pass. label Nov 11, 2020
@gcf-merge-on-green gcf-merge-on-green Bot merged commit c8860a6 into master Nov 11, 2020
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datastore Issues related to the googleapis/python-ndb API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python NDB Library Issue

3 participants