Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

fix: support empty not_finished messages that cause query.count() to return early#580

Merged
gcf-merge-on-green[bot] merged 1 commit into
masterfrom
support_empty_not_finished
Dec 7, 2020
Merged

fix: support empty not_finished messages that cause query.count() to return early#580
gcf-merge-on-green[bot] merged 1 commit into
masterfrom
support_empty_not_finished

Conversation

@crwilcox
Copy link
Copy Markdown
Contributor

@crwilcox crwilcox commented Dec 7, 2020

fixes #575

@crwilcox crwilcox requested a review from andrewsg as a code owner December 7, 2020 20:37
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 7, 2020
@product-auto-label product-auto-label Bot added the api: datastore Issues related to the googleapis/python-ndb API. label Dec 7, 2020
andrewsg
andrewsg approved these changes Dec 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewsg andrewsg added the automerge Merge the pull request once unit tests and other checks pass. label Dec 7, 2020
@gcf-merge-on-green gcf-merge-on-green Bot merged commit fc31553 into master Dec 7, 2020
@gcf-merge-on-green gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 7, 2020
@gaborfeher
Copy link
Copy Markdown
Contributor

gaborfeher commented Dec 11, 2020

@crwilcox @andrewsg I've tried this on my prod data and it looks like it is causing an infinite loop. I'll write more details in the issue soon. In the meantime I think it'd be a good idea to hold off the next release.

@crwilcox
Copy link
Copy Markdown
Contributor Author

crwilcox commented Dec 11, 2020

Thanks @gaborfeher. If you identify the scenario it would be good for us to grow our test coverage to include it.

@crwilcox crwilcox mentioned this pull request Dec 11, 2020
Merged
@andrewsg
Copy link
Copy Markdown
Contributor

andrewsg commented Dec 11, 2020

Thanks for the heads-up!

@gaborfeher gaborfeher mentioned this pull request Dec 12, 2020
Closed
@gaborfeher
Copy link
Copy Markdown
Contributor

gaborfeher commented Dec 12, 2020

@crwilcox @andrewsg I've made an issue and a PR: #584 #585

@andrewsg
Copy link
Copy Markdown
Contributor

andrewsg commented Dec 16, 2020

@gaborfeher Thanks again for your help. It looks like we should be good to go now that your PR is merged. All clear?

@gaborfeher
Copy link
Copy Markdown
Contributor

gaborfeher commented Dec 16, 2020

@andrewsg yep, all clear from me & thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@andrewsg andrewsg andrewsg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: datastore Issues related to the googleapis/python-ndb API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

query.count() misses results sometimes

3 participants

@crwilcox @gaborfeher @andrewsg