Skip to content
This repository was archived by the owner on May 6, 2026. It is now read-only.

fix: prevent mismatch error when using default namespace on ancestor queries#614

Merged
crwilcox merged 4 commits into
googleapis:masterfrom
chrisrossi:577-ancestor-queries
Mar 24, 2021
Merged

fix: prevent mismatch error when using default namespace on ancestor queries#614
crwilcox merged 4 commits into
googleapis:masterfrom
chrisrossi:577-ancestor-queries

Conversation

@chrisrossi
Copy link
Copy Markdown
Contributor

Also fixes bug that was discovered while working this where keys weren't properly inheriting the namespace of their parent.

Fixes #577

@chrisrossi chrisrossi requested a review from andrewsg as a code owner February 23, 2021 18:47
@chrisrossi chrisrossi requested a review from a team February 23, 2021 18:47
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Feb 23, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@product-auto-label product-auto-label Bot added the api: datastore Issues related to the googleapis/python-ndb API. label Feb 23, 2021
@google-cla google-cla Bot added the cla: no This human has *not* signed the Contributor License Agreement. label Feb 23, 2021
@chrisrossi
Copy link
Copy Markdown
Contributor Author

This supercedes #604, since I can't push to Carlos's fork.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Feb 23, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Mar 23, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@chrisrossi
Copy link
Copy Markdown
Contributor Author

Hi, @cguardia. Do you mind appeasing cla-bot by leaving a "@googlebot I consent." comment for us?

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Mar 23, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Mar 23, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@cguardia
Copy link
Copy Markdown
Contributor

@googlebot I consent.

@google-cla google-cla Bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 24, 2021
@crwilcox crwilcox merged commit ae67f04 into googleapis:master Mar 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: datastore Issues related to the googleapis/python-ndb API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NDB: Cannot Query/fetch using ancestors stored in default namespace from another namespace

3 participants