Model.get or insert #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
chrisrossi
commented
May 10, 2019
| """ | ||
| if not self.mutations: | ||
| return | ||
| # It's tempting to do something like: |
Contributor
Author
There was a problem hiding this comment.
Found this bug in the system tests for this feature. Left in this warning for future optimizers.
chrisrossi
commented
May 10, 2019
| "MetaModel", | ||
| "Model", | ||
| "Expando", | ||
| "transaction", |
Contributor
Author
There was a problem hiding this comment.
These were already implemented in _transaction.py. Belatedly removing their stubs from model.py
andrewsg
approved these changes
May 10, 2019
src/google/cloud/ndb/model.py
Outdated
| Returns: | ||
| tasklets.Future: tuple[key.Key]: Keys for the newly allocated IDs. | ||
| tasklets.Future: Optional[Model]: The retreived entity, if one is |
chrisrossi
force-pushed
the
Model.get_or_insert
branch
from
fbc7054 to
5e027c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff base is #91