Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

add idle vm observation period decrement example#205

Closed
mhmatt wants to merge 3 commits intogoogleapis:mainfrom
mhmatt:main
Closed

add idle vm observation period decrement example#205
mhmatt wants to merge 3 commits intogoogleapis:mainfrom
mhmatt:main

Conversation

@mhmatt
Copy link

@mhmatt mhmatt commented May 26, 2022

Adds a function to decrement idle vm recommender config observation period, printing current and updated values.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [x ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Adds a function to decrement idle vm recommender config observation period, printing current and updated values.
@mhmatt mhmatt requested a review from a team as a code owner May 26, 2022 01:01
@mhmatt mhmatt requested a review from dandhlee May 26, 2022 01:01
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: recommender Issues related to the googleapis/python-recommender API. labels May 26, 2022
@parthea
Copy link
Contributor

parthea commented Nov 25, 2022

I'm going to close this PR because the code generator that generates the samples lives in another repo. googleapis/gapic-generator-python#1499

@parthea parthea closed this Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: recommender Issues related to the googleapis/python-recommender API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants