This repository was archived by the owner on Jul 6, 2023. It is now read-only.
chore: Update synth.py to work around generator issue #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: servicecontrol
busunkim96
approved these changes
Apr 5, 2021
Contributor
busunkim96
left a comment
busunkim96
left a comment
There was a problem hiding this comment.
LGTM. Please also file a bug in the generator repo to track fixing this.
Isn't it a holiday in Canada today? :)
parthea
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to this comment where I manually edited a file in order to work around a docs generation issue. This PR updates
synth.pyto automatically apply the workaround.