Skip to content
This repository was archived by the owner on Mar 13, 2026. It is now read-only.

fix: for open-telemetry status code spec change#88

Merged
vi3k6i5 merged 14 commits intogoogleapis:mainfrom
vi3k6i5:ot_update
Jun 17, 2021
Merged

fix: for open-telemetry status code spec change#88
vi3k6i5 merged 14 commits intogoogleapis:mainfrom
vi3k6i5:ot_update

Conversation

@vi3k6i5
Copy link
Copy Markdown
Contributor

@vi3k6i5 vi3k6i5 commented Jun 11, 2021

Updated support for open telemetry tracing and updated setup.py extra dependency.
Also added unit tests for open telemetry.

fixes #89

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 11, 2021
@vi3k6i5 vi3k6i5 requested review from larkee and skuruppu June 11, 2021 17:07
Copy link
Copy Markdown
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, currently the new tests aren't being run. Please add a unit nox session to noxfile.py similar to here.

Comment thread test/_helpers.py Outdated
@vi3k6i5 vi3k6i5 requested a review from larkee June 16, 2021 17:32
@vi3k6i5
Copy link
Copy Markdown
Contributor Author

vi3k6i5 commented Jun 16, 2021

LGTM. However, currently the new tests aren't being run. Please add a unit nox session to noxfile.py similar to here.

Added the same.

Comment thread noxfile.py Outdated
@vi3k6i5 vi3k6i5 requested a review from larkee June 17, 2021 07:29
Comment thread noxfile.py Outdated
@vi3k6i5 vi3k6i5 requested a review from larkee June 17, 2021 08:40
@vi3k6i5 vi3k6i5 merged commit c0d39cc into googleapis:main Jun 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update open telemetry tracing code according to new spec.

2 participants