chore: librarian release pull request: 20251118T221423Z #1458
Conversation
product-auto-label
bot
added
the
api: spanner
Summary of ChangesHello @ohmayr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request marks a significant shift in the project's automation infrastructure by transitioning to the Librarian CLI for release management and code generation. Concurrently, it delivers the latest Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, created by the Librarian CLI, prepares for the 3.60.0 release of google-cloud-spanner. The changes primarily involve updating version numbers, migrating from OwlBot to the Librarian generation tool, and refreshing configuration files.
My review has identified a few minor issues in the newly generated files:
- A potential typo in a regex in
.librarian/state.yamlthat could affect file cleanup. - Some redundant code and a minor formatting issue in
.librarian/generator-input/setup.py. - Unnecessary Unicode string prefixes (
u"...") indocs/conf.pyfor a Python 3+ project.
These are detailed in the review comments. Overall, the automated changes look correct and align with the goal of preparing a new release with updated tooling.
| - ^setup.py | ||
| - ^testing/constraints-3.8 | ||
| - ^testing/constraints-3.9 | ||
| - ^testing/constraints-3.1 |
There was a problem hiding this comment.
The regex ^testing/constraints-3.1 seems to contain a typo. Given the other constraint files and supported Python versions (e.g., 3.9, 3.10, 3.11, 3.12), this was likely intended to target a more recent Python 3 version, such as 3.10. Please correct this to ensure the correct old constraint files are removed.
- ^testing/constraints-3.10| "opentelemetry-semantic-conventions >= 0.43b0", | ||
| "opentelemetry-resourcedetector-gcp >= 1.8.0a0", | ||
| "google-cloud-monitoring >= 2.16.0", | ||
| "mmh3 >= 4.1.0 ", |
There was a problem hiding this comment.
There's a trailing space in the version specifier for mmh3. While many tools might handle this gracefully, it's best to remove it for correctness and to prevent potential parsing issues.
| "mmh3 >= 4.1.0 ", | |
| "mmh3 >= 4.1.0", |
|
|
||
| url = "https://github.com/googleapis/python-spanner" | ||
|
|
||
| package_root = os.path.abspath(os.path.dirname(__file__)) |
There was a problem hiding this comment.
The package_root variable is redefined here. It was already defined on line 21. This redefinition is redundant and can be removed.
| project = u"google-cloud-spanner" | ||
| copyright = u"2025, Google, LLC" | ||
| author = u"Google APIs" |
There was a problem hiding this comment.
The u prefix for strings is unnecessary in Python 3 (this project requires >=3.9), as all strings are Unicode by default. These prefixes can be removed for cleaner code.
| project = u"google-cloud-spanner" | |
| copyright = u"2025, Google, LLC" | |
| author = u"Google APIs" | |
| project = "google-cloud-spanner" | |
| copyright = "2025, Google, LLC" | |
| author = "Google APIs" |
| root_doc, | ||
| "google-cloud-spanner.tex", | ||
| "google-cloud-spanner Documentation", | ||
| u"google-cloud-spanner Documentation", |
There was a problem hiding this comment.
The u prefix for this string is unnecessary in Python 3, as all strings are Unicode by default. It can be removed for cleaner code.
| u"google-cloud-spanner Documentation", | |
| "google-cloud-spanner Documentation", |
2 participants
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release.
Librarian Version: v1.0.0
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:e601da6e29c993e14c52867f2c088dfb841beae618d2a4f1e0f7970a888ab020
google-cloud-spanner: 3.60.0
3.60.0 (2025-11-18)
Features
Exposing AutoscalingConfig in InstancePartition (8b6f1540)
add support for experimental host (feat: add support for experimental host #1452) (9535e5e0)
enable OpenTelemetry metrics and tracing by default (feat(observability): enable OpenTelemetry metrics and tracing by default #1410) (bb5095df)
add cloud.region, request_tag and transaction_tag in span attributes (feat: add cloud.region, request_tag and transaction_tag in span attributes #1449) (d37fb80a)
Bug Fixes
Deprecate credentials_file argument (8b6f1540)
configure keepAlive time for gRPC TCP connections (fix: configure keepAlive time for gRPC TCP connections #1448) (efb2833e)