Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for low-cost instances #313

Merged
merged 4 commits into from Jun 23, 2021
Merged

feat: add support for low-cost instances #313

merged 4 commits into from Jun 23, 2021

Conversation

zoercai
Copy link
Contributor

@zoercai zoercai commented Apr 22, 2021

Allow users to create an instance using processing_units.
1 node = 1000 processing units. There is currently a default node count used if node count is not specified.
create and update now only update processing units rather than node count, as only one can be specified.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@zoercai zoercai requested review from as code owners Apr 22, 2021
@zoercai zoercai requested review from leahecole and removed request for Apr 22, 2021
@product-auto-label product-auto-label bot added the api: spanner label Apr 22, 2021
@google-cla google-cla bot added the cla: yes label Apr 22, 2021
@zoercai zoercai requested a review from larkee Apr 22, 2021
@zoercai zoercai added the do not merge label Apr 22, 2021
tests/system/test_system.py Show resolved Hide resolved
google/cloud/spanner_v1/client.py Outdated Show resolved Hide resolved
google/cloud/spanner_v1/client.py Show resolved Hide resolved
google/cloud/spanner_v1/instance.py Outdated Show resolved Hide resolved
tests/unit/test_client.py Outdated Show resolved Hide resolved
@leahecole
Copy link
Contributor

@leahecole leahecole commented Apr 23, 2021

I think it's adding me as a reviewer because of the synthtool changes in .github/header-checker-lint.yml and those LGTM :)

@zoercai zoercai requested a review from larkee Apr 26, 2021
google/cloud/spanner_v1/instance.py Outdated Show resolved Hide resolved
google/cloud/spanner_v1/instance.py Outdated Show resolved Hide resolved
@zoercai zoercai requested a review from larkee Apr 26, 2021
Copy link
Contributor

@larkee larkee left a comment

Just a couple comments to go with the proposed changes to resolve the update issue we discussed 👍

google/cloud/spanner_v1/instance.py Outdated Show resolved Hide resolved
tests/system/test_system.py Outdated Show resolved Hide resolved
@zoercai zoercai requested a review from larkee May 7, 2021
@leahecole leahecole removed their request for review Jun 4, 2021
larkee
larkee approved these changes Jun 21, 2021
google/cloud/spanner_v1/instance.py Outdated Show resolved Hide resolved
zoercai and others added 2 commits Jun 22, 2021
Co-authored-by: larkee <31196561+larkee@users.noreply.github.com>
@zoercai zoercai removed the do not merge label Jun 22, 2021
google/cloud/spanner_v1/instance.py Outdated Show resolved Hide resolved
Co-authored-by: larkee <31196561+larkee@users.noreply.github.com>
@larkee larkee added the kokoro:force-run label Jun 23, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jun 23, 2021
@larkee larkee added the kokoro:force-run label Jun 23, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Jun 23, 2021
@larkee larkee merged commit 44aa7cc into googleapis:master Jun 23, 2021
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants