-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for low-cost instances #313
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: spanner
Issues related to the googleapis/python-spanner API.
label
Apr 22, 2021
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Apr 22, 2021
zoercai
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Apr 22, 2021
larkee
requested changes
Apr 22, 2021
I think it's adding me as a reviewer because of the synthtool changes in |
larkee
reviewed
Apr 26, 2021
larkee
reviewed
May 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple comments to go with the proposed changes to resolve the update issue we discussed 👍
larkee
approved these changes
Jun 21, 2021
Co-authored-by: larkee <31196561+larkee@users.noreply.github.com>
zoercai
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Jun 22, 2021
larkee
reviewed
Jun 22, 2021
Co-authored-by: larkee <31196561+larkee@users.noreply.github.com>
larkee
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 23, 2021
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 23, 2021
larkee
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 23, 2021
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: spanner
Issues related to the googleapis/python-spanner API.
cla: yes
This human has signed the Contributor License Agreement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to create an instance using
processing_units
.1 node = 1000 processing units. There is currently a default node count used if node count is not specified.
create
andupdate
now only update processing units rather than node count, as only one can be specified.Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: