-
Notifications
You must be signed in to change notification settings - Fork 171
chore: librarian release pull request: 20260202T123858Z #1736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @chandra-siri, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the release process for the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request prepares for the 4.0.0 release by updating the version number across several files and adding the new changelog entry. My review focuses on the new changelog, where I've identified and suggested fixes for a few duplicate entries to improve its clarity and conciseness. The rest of the changes look good for a release.
…experimental` folder
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request appears to be an automated release for version 3.9.0. The changes primarily consist of version bumps and an updated changelog. I've reviewed the changelog and found a few areas for improvement to enhance its clarity and correctness, mainly related to duplicate and redundant entries. Please see my specific comments for details.
| ### Features | ||
|
|
||
| * add get_object method for async grpc client (#1735) ([0e5ec29bc6a31b77bcfba4254cef5bffb199095c](https://github.com/googleapis/python-storage/commit/0e5ec29bc6a31b77bcfba4254cef5bffb199095c)) | ||
| * expose `DELETE_OBJECT` in `AsyncGrpcClient` (#1718) ([c8dd7a0b124c395b7b60189ee78f47aba8d51f7d](https://github.com/googleapis/python-storage/commit/c8dd7a0b124c395b7b60189ee78f47aba8d51f7d)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are extra spaces after DELETE_OBJECT which affect formatting. Please remove them.
| * expose `DELETE_OBJECT` in `AsyncGrpcClient` (#1718) ([c8dd7a0b124c395b7b60189ee78f47aba8d51f7d](https://github.com/googleapis/python-storage/commit/c8dd7a0b124c395b7b60189ee78f47aba8d51f7d)) | |
| * expose `DELETE_OBJECT` in `AsyncGrpcClient` (#1718) ([c8dd7a0b124c395b7b60189ee78f47aba8d51f7d](https://github.com/googleapis/python-storage/commit/c8dd7a0b124c395b7b60189ee78f47aba8d51f7d)) |
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release.
Librarian Version: v1.0.2-0.20251119154421-36c3e21ad3ac
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:8e2c32496077054105bd06c54a59d6a6694287bc053588e24debe6da6920ad91
google-cloud-storage: 3.9.0
3.9.0 (2026-02-02)
Features
update generation for MRD (feat: update generation for MRD #1730) (08bc7082)
add get_object method for async grpc client (feat: add get_object method for async grpc client #1735) (0e5ec29b)
Add micro-benchmarks for reads comparing standard (regional) vs rapid (zonal) buckets. (feat: Add micro-benchmarks for reads comparing standard (regional) vs rapid (zonal) buckets. #1697) (1917649f)
Add support for opening via
write_handleand fixwrite_handletype (feat: Add support for opening viawrite_handleand fixwrite_handletype #1715) (2bc15fa5)add samples for appendable objects writes and reads (2e1a1eb5)
add samples for appendable objects writes and reads (feat(samples): add samples for appendable objects writes and reads #1705) (2e1a1eb5)
add context manager to mrd (feat: add context manager to mrd #1724) (5ac2808a)
Move Zonal Buckets features of
_experimental(feat: Move Zonal Buckets features of_experimental#1728) (74c9ecc5)add default user agent for grpc (feat: add default user agent for grpc #1726) (7b319469)
expose finalized_time in blob.py applicable for GET_OBJECT in ZB (feat: expose finalized_time in blob.py applicable for GET_OBJECT in ZB #1719) (8e21a7fe)
expose
DELETE_OBJECTinAsyncGrpcClient(feat: exposeDELETE_OBJECTinAsyncGrpcClient#1718) (c8dd7a0b)send
user_agentto grpc channel (feat(grpc_user_agent): senduser_agentto grpc channel #1712) (cdb2486b)integrate writes strategy and appendable object writer (feat(experimental): integrate writes strategy and appendable object writer #1695) (dbd162b3)
Add micro-benchmarks for writes comparing standard (regional) vs rapid (zonal) buckets. (feat: Add micro-benchmarks for writes comparing standard (regional) vs rapid (zonal) buckets. #1707) (dbe9d8b8)
add support for
generation=0to avoid overwriting existing objects and addis_stream_opensupport (feat(ZonalBuckets): add support forgeneration=0to avoid overwriting existing objects and addis_stream_opensupport #1709) (ea0f5bf8)add support for
generation=0to prevent overwriting existing objects (ea0f5bf8)add
is_stream_openproperty to AsyncAppendableObjectWriter for stream status check (ea0f5bf8)Bug Fixes
receive eof while closing reads stream (fix: receive eof while closing reads stream #1733) (2ef63396)
update write handle on every recv() (fix: update write handle on every recv() #1716) (5d9fafe1)
implement requests_done method to signal end of requests in async streams. Gracefully close streams. (fix(experimental): implement requests_done method to signal end of requests in async streams. Gracefully close streams. #1700) (6c160794)
implement requests_done method to signal end of requests in async streams. Gracefully close streams. (6c160794)
instance grpc client once per process in benchmarks (fix: instance grpc client once per process in benchmarks #1725) (721ea2dd)
Fix formatting in setup.py dependencies list (fix: Fix formatting in setup.py dependencies list #1713) (cc4831d7)
Change contructors of MRD and AAOW AsyncGrpcClient.grpc_client to AsyncGrpcClient (fix!: Change contructors of MRD and AAOW AsyncGrpcClient.grpc_client to AsyncGrpcClient #1727) (e730bf50)