Skip to content

fix(sequential-calls): Use push instead of concat when returning releases#1865

Merged
chingor13 merged 1 commit intogoogleapis:mainfrom
erezrokah:fix/empty_releases_sequential_calls
Mar 7, 2023
Merged

fix(sequential-calls): Use push instead of concat when returning releases#1865
chingor13 merged 1 commit intogoogleapis:mainfrom
erezrokah:fix/empty_releases_sequential_calls

Conversation

@erezrokah
Copy link
Copy Markdown
Contributor

@erezrokah erezrokah commented Feb 27, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1864 🦕
Fixes https://github.com/google-github-actions/release-please-action/issues/546
Also fixes cloudquery/cloudquery#7787

@erezrokah erezrokah requested review from a team February 27, 2023 16:28
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Feb 27, 2023
@erezrokah erezrokah changed the title fix(sequential-calls): Use push instead of contact when returning releases fix(sequential-calls): Use push instead of concat when returning releases Feb 27, 2023
erezrokah
erezrokah commented Feb 27, 2023
View reviewed changes
Comment thread src/manifest.ts
pullRequestsByNumber[pullNumber]
);
resultReleases.concat(releases);
resultReleases.push(...releases);
Copy link
Copy Markdown
Contributor Author

@erezrokah erezrokah Feb 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concat does not modify the array, it always returns a new one

This was referenced Feb 27, 2023
Closed
Closed
@erezrokah
Copy link
Copy Markdown
Contributor Author

erezrokah commented Feb 28, 2023 •
edited
Loading

Could also fix https://github.com/google-github-actions/release-please-action/issues/546 It does fix it

@erezrokah
Copy link
Copy Markdown
Contributor Author

erezrokah commented Mar 7, 2023

Hi lovely release please team 👋 Is there anything missing on my end I should add to this PR?

@chingor13 chingor13 merged commit 1026c73 into googleapis:main Mar 7, 2023
@release-please release-please bot mentioned this pull request Mar 7, 2023
Merged
@erezrokah
Copy link
Copy Markdown
Contributor Author

erezrokah commented Mar 8, 2023

Thanks for the review, merge and quick release 🚀

@erezrokah erezrokah deleted the fix/empty_releases_sequential_calls branch March 8, 2023 15:44
@erezrokah erezrokah mentioned this pull request Apr 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

Labels

size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

2 participants

@erezrokah @chingor13