Skip to content

[ggj][codegen] fix: privately-scoped vars in ServiceClientTest codegen #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2020
Merged

[ggj][codegen] fix: privately-scoped vars in ServiceClientTest codegen #377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/google/api/generator/gapic/composer/ServiceClientTestClassComposer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ private static List<Statement> createClassMemberFieldDecls(
ExprStatement.withExpr(
v.toBuilder()
.setIsDecl(true)
.setScope(ScopeNode.PUBLIC)
.setScope(ScopeNode.PRIVATE)
.setIsStatic(v.type().reference().name().startsWith("Mock"))
.build()))
.collect(Collectors.toList());
Expand Down
8 changes: 4 additions & 4 deletions src/test/java/com/google/api/generator/gapic/composer/goldens/EchoClientTest.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ import org.junit.Test;

@Generated("by gapic-generator-java")
public class EchoClientTest {
public static MockServiceHelper mockServiceHelper;
public static MockEcho mockEcho;
public EchoClient client;
public LocalChannelProvider channelProvider;
private static MockServiceHelper mockServiceHelper;
private static MockEcho mockEcho;
private EchoClient client;
private LocalChannelProvider channelProvider;

@BeforeClass
public static void startStaticServer() {
Expand Down