Skip to content

[ggj][engx] fix: switch assertEquals (actual,expected) args order in JavaDocCommentTest #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 18, 2020
Merged

[ggj][engx] fix: switch assertEquals (actual,expected) args order in JavaDocCommentTest #503

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a3c89f5
fix: Update LRO initial_retry_delayo o 5s (discussion in doc)
miraleung Nov 17, 2020
b4a1ba9
fix: correct some common typos
miraleung Nov 17, 2020
8c9d12d
fix: switch assertEquals (actual,expected) args order in JavaDocComme…
miraleung Nov 17, 2020
d60b04c
Merge branch 'master' of github.com:googleapis/gapic-generator-java i…
miraleung Nov 17, 2020
7fdee88
fix: merge master
miraleung Nov 17, 2020
81ad213
Merge branch 'gp/g1' of github.com:googleapis/gapic-generator-java in…
miraleung Nov 17, 2020
2945877
Merge branch 'master' into gp/g2
miraleung Nov 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/test/java/com/google/api/generator/engine/ast/JavaDocCommentTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public class JavaDocCommentTest {
public void createJavaDocComment_basic() {
String content = "this is a test comment";
JavaDocComment javaDocComment = JavaDocComment.builder().addComment(content).build();
assertEquals(javaDocComment.comment(), content);
assertEquals(content, javaDocComment.comment());
}

@Test
Expand All @@ -51,7 +51,7 @@ public void createJavaDocComment_specialCharacter() {
+ " libraryClient.createShelfCallable().futureCall(request);\n"
+ "}</pre>\n"
+ "@throws Exception This is an exception.";
assertEquals(javaDocComment.comment(), expected);
assertEquals(expected, javaDocComment.comment());
}

@Test
Expand All @@ -65,7 +65,7 @@ public void createJavaDocComment_sampleCode() {
+ "<pre>{@code\n"
+ "resource = project/{project}/shelfId/{shelfId}\n"
+ "}</pre>";
assertEquals(javaDocComment.comment(), expected);
assertEquals(expected, javaDocComment.comment());
}

@Test
Expand Down Expand Up @@ -122,7 +122,7 @@ public void createJavaDocComment_multipleComments() {
+ "<li> A request object method.\n"
+ "<li> A callable method.\n"
+ "</ol>";
assertEquals(javaDocComment.comment(), expected);
assertEquals(expected, javaDocComment.comment());
}

@Test
Expand All @@ -143,7 +143,7 @@ public void createJavaDocComment_multipleParams() {
"This is a block comment.\n"
+ "@param shelfName The name of the shelf where books are published to.\n"
+ "@param shelfId The shelfId of the shelf where books are published to.";
assertEquals(javaDocComment.comment(), expected);
assertEquals(expected, javaDocComment.comment());
}

@Test
Expand All @@ -168,7 +168,7 @@ public void createJavaDocComment_throwsAndDeprecated() {
String expected =
"@throws java.lang.RuntimeException if the remote call fails.\n"
+ "@deprecated Use the {@link ShelfBookName} class instead.";
assertEquals(javaDocComment.comment(), expected);
assertEquals(expected, javaDocComment.comment());
}

@Test
Expand Down Expand Up @@ -219,7 +219,7 @@ public void createJavaDocComment_allComponents() {
+ "@param shelf The shelf to create.\n"
+ "@throws com.google.api.gax.rpc.ApiException if the remote call fails.\n"
+ "@deprecated Use the {@link ArchivedBookName} class instead.";
assertEquals(javaDocComment.comment(), expected);
assertEquals(expected, javaDocComment.comment());
}

private static String createLines(int numLines) {
Expand Down